Here's a pretty balanced take on the matter of Trump's apparent fondness of getting Generals involved in his government, from the CSM.
As for the one who is definitely wanted by Trump at the moment - Mattis - I wouldn't have thought that a Marine leader who is likened by Trump to Patton (with a history of somewhat over the top motivational quips to his troops) would be a good choice. Yet the New York Times has endorsed him in an opinion piece and editorially. And Trump himself says that Mattis has told him that he is against torture, due to it not being effective.
So, maybe he would be OK? I dunno, I sorta just don't really trust Marines, though, to be honest. Their earnestness puts me off.